Feature issue 376 #381
Closed
Feature issue 376 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and add a new test
…, and add a new test
|
Thanks a lot for this suggestion. I agree with it. Will merge for inclusion in 0.9.15 |
|
It seems I can't merge it anymore since you closed it. Is there any reason for your closing it? If I merge your PR, you'll get credit for it in the commit history. Otherwise, I'll go ahead and copy the contents... |
|
Nevermind. It seems you've submitted another PR later: #382 |
|
Duplicate of #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#376
If the
percentileis 0 or 1, it's unnecessary to sort all the elements in the container before getting the output by the index; instead, we can just scan all the items in one traversal and get the minimum or maximum with a time complexity of O(n).All the tests passed after the modification. Besides, in the test
testPercentileWithStringsAndFunction, since the function isString::lengthand each string in the stream is of length 1, the sorting result should be the same as the original order of the input elements.I think the orginal test is not enough, so I add a new test for the function
percentileBy.Edit: add a second test.